-
Notifications
You must be signed in to change notification settings - Fork 3.8k
The latest protobuf pkg 5.28.0 is failing on Windows. use the one pre… #6342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oriing it for testing Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Test Results0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s For more details on these parsing errors, see this check. Results for commit 05325d3. ± Comparison against base commit 37ec1d1. ♻️ This comment has been updated with latest results. |
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
justinchuby
reviewed
Sep 4, 2024
justinchuby
approved these changes
Sep 4, 2024
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
roborags
pushed a commit
that referenced
this pull request
Sep 4, 2024
#6342) …oriing it for testing ### Description <!-- - Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> --------- Signed-off-by: Liqun Fu <liqfu@microsoft.com>
roborags
added a commit
that referenced
this pull request
Sep 4, 2024
### Description Cherry-Pick (#6342) - The latest protobuf pkg 5.28.0 is failing on Windows. use the one pre… into the `rel-1.17.0` branch ### Motivation and Context Cherry pick commit to `rel-1.17.0` to fix protobuf package issue in windows testing Signed-off-by: Liqun Fu <liqfu@microsoft.com> Co-authored-by: liqun Fu <liqfu@microsoft.com>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
onnx#6342) …oriing it for testing ### Description <!-- - Describe your changes. --> ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> --------- Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oriing it for testing
Description
Motivation and Context