Skip to content

Conversation

Yosshi999
Copy link
Contributor

Description

Motivation and Context

Fix #6294

Signed-off-by: Yosshi999 <Yosshi999@users.noreply.github.com>
Signed-off-by: Yosshi999 <Yosshi999@users.noreply.github.com>
@Yosshi999 Yosshi999 requested review from a team as code owners August 27, 2024 16:34
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.23%. Comparing base (83194ed) to head (2d37d28).
Report is 98 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6323      +/-   ##
==========================================
+ Coverage   56.95%   57.23%   +0.28%     
==========================================
  Files         506      507       +1     
  Lines       30467    31407     +940     
  Branches     4592     4691      +99     
==========================================
+ Hits        17353    17977     +624     
- Misses      12285    12576     +291     
- Partials      829      854      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yosshi999 <Yosshi999@users.noreply.github.com>
Copy link
Contributor

@gramalingam gramalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. However, I am curious what other frameworks (numpy, pytorch, tf, etc.) do when broadcasting (1) and (0) ... whether they support it or reject it.

@gramalingam gramalingam added this pull request to the merge queue Sep 3, 2024
Merged via the queue into onnx:main with commit 81b2537 Sep 4, 2024
40 checks passed
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
…zero (onnx#6323)

### Description
<!-- - Describe your changes. -->

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
Fix onnx#6294

---------

Signed-off-by: Yosshi999 <Yosshi999@users.noreply.github.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Shape inference segfaults when adding tensors of shapes (0,) and (1,)
2 participants