Fix missing secrets for publishing of onnxweekly #6321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6321 +/- ##
==========================================
+ Coverage 56.95% 57.26% +0.30%
==========================================
Files 506 507 +1
Lines 30467 31354 +887
Branches 4592 4679 +87
==========================================
+ Hits 17353 17954 +601
- Misses 12285 12549 +264
- Partials 829 851 +22 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Aug 26, 2024
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description After the release-pipeline upgrade (onnx#6277) the publishing the weekly does not work any more as the secrets are not available at the resuable workflows ( https://github.com/onnx/onnx/actions/runs/10551283959/job/29228497156 ) Link for the option I used for the secrets: https://github.blog/changelog/2022-05-03-github-actions-simplify-using-secrets-with-reusable-workflows ### Motivation and Context In my opinion, we no longer need these secrets at the end. In the future, the publishing of the Onnx weekly builds will be solved via “trusted publishing” outside the individual OS release pipelines. This is already included in create_release.yml. Currently, the previous weeklys are published at pypi.org, in the test via trusted publishing at test.pypi.org After a successful schedule test (next Monday), we could adjust the publishing. a) e.g. throw out the upload steps with twine and adjust the target of separate steps... b) or leave it as it is for now... Signed-off-by: Andreas Fehlner <fehlner@arcor.de> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the release-pipeline upgrade (#6277)
the publishing the weekly does not work any more as the secrets are not available at the resuable workflows (
https://github.com/onnx/onnx/actions/runs/10551283959/job/29228497156 )
Link for the option I used for the secrets:
https://github.blog/changelog/2022-05-03-github-actions-simplify-using-secrets-with-reusable-workflows
Motivation and Context
In my opinion, we no longer need these secrets at the end.
In the future, the publishing of the Onnx weekly builds will be solved via “trusted publishing” outside the individual OS release pipelines. This is already included in create_release.yml. Currently, the previous weeklys are published at pypi.org, in the test via trusted publishing at test.pypi.org
After a successful schedule test (next Monday), we could adjust the publishing. a) e.g. throw out the upload steps with twine and adjust the target of separate steps... b) or leave it as it is for now...