Fix shape inference for Squeeze-1,11 with dynamic input shape #6314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yosshi999 <Yosshi999@users.noreply.github.com>
Signed-off-by: Yosshi999 <Yosshi999@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6314 +/- ##
==========================================
+ Coverage 56.95% 57.23% +0.27%
==========================================
Files 506 507 +1
Lines 30467 31404 +937
Branches 4592 4691 +99
==========================================
+ Hits 17353 17974 +621
- Misses 12285 12577 +292
- Partials 829 853 +24 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yosshi999 <Yosshi999@users.noreply.github.com>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
) ### Description <!-- - Describe your changes. --> Early return causes wrong shape inference. When input has dynamic axes and Squeeze-11' axes is missing, output shape was always inferred as scalar. This will lead to validation error in downstream nodes. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Fix onnx#6313 --------- Signed-off-by: Yosshi999 <Yosshi999@users.noreply.github.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
sevenc-nanashi
added a commit
to sevenc-nanashi/onnxruntime-builder
that referenced
this pull request
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Early return causes wrong shape inference. When input has dynamic axes and Squeeze-11' axes is missing, output shape was always inferred as scalar. This will lead to validation error in downstream nodes.
Motivation and Context
Fix #6313