Remove unused variables #6303
Merged
Remove unused variables #6303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cyy <cyyever@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6303 +/- ##
==========================================
+ Coverage 56.95% 57.19% +0.24%
==========================================
Files 506 507 +1
Lines 30467 31256 +789
Branches 4592 4663 +71
==========================================
+ Hits 17353 17878 +525
- Misses 12285 12531 +246
- Partials 829 847 +18 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Aug 19, 2024
|
Thanks! |
roborags
pushed a commit
that referenced
this pull request
Aug 26, 2024
### Description <!-- - Describe your changes. --> Remove some unused variables detected by static analyzer. ### Motivation and Context For better code. <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: cyy <cyyever@outlook.com>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Aug 26, 2024
### Description <!-- - Describe your changes. --> Remove some unused variables detected by static analyzer. ### Motivation and Context For better code. <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: cyy <cyyever@outlook.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
roborags
pushed a commit
that referenced
this pull request
Aug 28, 2024
### Description <!-- - Describe your changes. --> Remove some unused variables detected by static analyzer. ### Motivation and Context For better code. <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: cyy <cyyever@outlook.com>
roborags
added a commit
that referenced
this pull request
Aug 29, 2024
### Description Cherry-Pick (#6303) - Remove unused variables into the `rel-1.17.0` branch ### Motivation and Context Cherry pick commit to `rel-17.0` branch to target 1.17 release Signed-off-by: cyy <cyyever@outlook.com> Co-authored-by: cyyever <cyyever@outlook.com>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description <!-- - Describe your changes. --> Remove some unused variables detected by static analyzer. ### Motivation and Context For better code. <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: cyy <cyyever@outlook.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove some unused variables detected by static analyzer.
Motivation and Context
For better code.