Handle the optional input in infer_node_outputs #6250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6250 +/- ##
==========================================
+ Coverage 56.95% 57.19% +0.24%
==========================================
Files 506 507 +1
Lines 30467 31256 +789
Branches 4592 4663 +71
==========================================
+ Hits 17353 17878 +525
- Misses 12285 12530 +245
- Partials 829 848 +19 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ice-tong <xych6@outlook.com>
4de441e to
a4a34c9
Compare
justinchuby
approved these changes
Jul 23, 2024
gramalingam
approved these changes
Jul 23, 2024
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Aug 26, 2024
### Description <!-- - Describe your changes. --> Fix onnx#6249 This PR handle the optional input in `onnx.shape_inference.infer_node_outputs` via skip the optional input type. The following modification are introduced: - `onnx/shape_inference.py` Skip the input type if the input name is "". - `onnx/test/inference_function_test.py` Add a unit test case of optioal input for `infer_node_outputs` ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> See onnx#6249 for more detail. Signed-off-by: ice-tong <xych6@outlook.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description <!-- - Describe your changes. --> Fix onnx#6249 This PR handle the optional input in `onnx.shape_inference.infer_node_outputs` via skip the optional input type. The following modification are introduced: - `onnx/shape_inference.py` Skip the input type if the input name is "". - `onnx/test/inference_function_test.py` Add a unit test case of optioal input for `infer_node_outputs` ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> See onnx#6249 for more detail. Signed-off-by: ice-tong <xych6@outlook.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #6249
This PR handle the optional input in
onnx.shape_inference.infer_node_outputsvia skip the optional input type. The following modification are introduced:onnx/shape_inference.pySkip the input type if the input name is "".onnx/test/inference_function_test.pyAdd a unit test case of optioal input forinfer_node_outputsMotivation and Context
See #6249 for more detail.