Use MACOSX_DEPLOYMENT_TARGET=12.0 for macOS wheels #6242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6242 +/- ##
==========================================
+ Coverage 56.95% 57.18% +0.23%
==========================================
Files 506 507 +1
Lines 30467 31249 +782
Branches 4592 4662 +70
==========================================
+ Hits 17353 17871 +518
- Misses 12285 12531 +246
- Partials 829 847 +18 ☔ View full report in Codecov by Sentry. |
It seems the latests wheels aren't respecting the 11.0 target for some reason. We can't test on macOS 11 anymore & macOS 11 is EOL. Move the tests to the lowest versioned runner available. Signed-off-by: mayeut <mayeut@users.noreply.github.com>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
### Description It seems the latests wheels aren't compatible with macOS 11 for some reason. We can't test on macOS 11 anymore & macOS 11 is EOL. Use MACOSX_DEPLOYMENT_TARGET=12.0 and move the tests to the lowest versioned runner available. Note: the delocate tool did not find anything wrong with the target being 11.0 on the 1.16.1 wheel. It should have complained if using symbols only compatible with 12.0+ so it seems MACOSX_DEPLOYMENT_TARGET=11.0 was indeed respected and the root cause of the issue is still unknown. ### Motivation and Context onnx#6191 Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Aug 26, 2024
### Description It seems the latests wheels aren't compatible with macOS 11 for some reason. We can't test on macOS 11 anymore & macOS 11 is EOL. Use MACOSX_DEPLOYMENT_TARGET=12.0 and move the tests to the lowest versioned runner available. Note: the delocate tool did not find anything wrong with the target being 11.0 on the 1.16.1 wheel. It should have complained if using symbols only compatible with 12.0+ so it seems MACOSX_DEPLOYMENT_TARGET=11.0 was indeed respected and the root cause of the issue is still unknown. ### Motivation and Context onnx#6191 Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description It seems the latests wheels aren't compatible with macOS 11 for some reason. We can't test on macOS 11 anymore & macOS 11 is EOL. Use MACOSX_DEPLOYMENT_TARGET=12.0 and move the tests to the lowest versioned runner available. Note: the delocate tool did not find anything wrong with the target being 11.0 on the 1.16.1 wheel. It should have complained if using symbols only compatible with 12.0+ so it seems MACOSX_DEPLOYMENT_TARGET=11.0 was indeed respected and the root cause of the issue is still unknown. ### Motivation and Context onnx#6191 Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems the latests wheels aren't compatible with macOS 11 for some reason.
We can't test on macOS 11 anymore & macOS 11 is EOL.
Use MACOSX_DEPLOYMENT_TARGET=12.0 and move the tests to the lowest versioned runner available.
Note: the delocate tool did not find anything wrong with the target being 11.0 on the 1.16.1 wheel. It should have complained if using symbols only compatible with 12.0+ so it seems MACOSX_DEPLOYMENT_TARGET=11.0 was indeed respected and the root cause of the issue is still unknown.
Motivation and Context
#6191