Handle functions in external data helper #6233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6233 +/- ##
==========================================
+ Coverage 56.95% 57.18% +0.23%
==========================================
Files 506 507 +1
Lines 30467 31249 +782
Branches 4592 4663 +71
==========================================
+ Hits 17353 17871 +518
- Misses 12285 12531 +246
- Partials 829 847 +18 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Jul 15, 2024
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: G. Ramalingam <grama@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: G. Ramalingam <grama@microsoft.com>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
The `external_data_helper.py` utilities do not handle model-local functions. Extend them to handle model-local functions. Add a test-case to validate. --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Aug 26, 2024
The `external_data_helper.py` utilities do not handle model-local functions. Extend them to handle model-local functions. Add a test-case to validate. --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
The `external_data_helper.py` utilities do not handle model-local functions. Extend them to handle model-local functions. Add a test-case to validate. --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
external_data_helper.pyutilities do not handle model-local functions. Extend them to handle model-local functions. Add a test-case to validate.