Refactor safe extract method to fix issue 6215 #6222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liqunfu <liqun.fu@microsoft.com>
onnx/utils.py
Outdated
|
|
||
|
|
||
| def extract_model_safe(model_tar_path: str, local_model_with_data_dir_path: str) -> None: | ||
| """ |
Check warning
Code scanning / lintrunner
RUFF/D212
Comment on lines
+294
to
+296
| members=_tar_members_filter( | ||
| model_with_data_zipped, local_model_with_data_dir_path | ||
| ), |
Check failure
Code scanning / CodeQL
Arbitrary file write during tarfile extraction
justinchuby
reviewed
Jul 10, 2024
justinchuby
reviewed
Jul 10, 2024
justinchuby
reviewed
Jul 10, 2024
gramalingam
approved these changes
Jul 12, 2024
|
@liqunfu : should we merge this? I think renaming |
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: liqun Fu <liqun.fu@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: liqun Fu <liqun.fu@microsoft.com>
| model_with_data_zipped.extractall( | ||
| path=local_model_with_data_dir_path, | ||
| members=_tar_members_filter( | ||
| model_with_data_zipped, local_model_with_data_dir_path |
Check failure
Code scanning / lintrunner
MYPY/arg-type
cjvolzka
pushed a commit
that referenced
this pull request
Jul 19, 2024
--------- Signed-off-by: liqunfu <liqfu@microsoft.com> Signed-off-by: liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 1b70f9b)
cjvolzka
pushed a commit
that referenced
this pull request
Jul 19, 2024
--------- Signed-off-by: liqunfu <liqfu@microsoft.com> Signed-off-by: liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 1b70f9b)
cjvolzka
pushed a commit
that referenced
this pull request
Jul 19, 2024
--------- Signed-off-by: liqunfu <liqfu@microsoft.com> Signed-off-by: liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 1b70f9b)
Closed
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
### Description onnx#6215 --------- Signed-off-by: liqunfu <liqun.fu@microsoft.com> Signed-off-by: liqun Fu <liqun.fu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
andife
pushed a commit
that referenced
this pull request
Jul 23, 2024
--------- Signed-off-by: liqunfu <liqfu@microsoft.com> Signed-off-by: liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 1b70f9b) Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Merged
cjvolzka
pushed a commit
that referenced
this pull request
Jul 29, 2024
--------- Signed-off-by: liqunfu <liqfu@microsoft.com> Signed-off-by: liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 1b70f9b)
cjvolzka
added a commit
that referenced
this pull request
Jul 30, 2024
### Description Check-pick commits from `main` into `rel-1.16.2` branch ### Motivation and Context Fix 1.16.1 issues and enabled 1.16.2 builds by cherry-picking the following PRs from `main` into the `1.16.2` branch * Fixes since 1.16.0 release * #6164 * #6222 * #6217 * #6255 * #6254 --------- Co-authored-by: sunflowersxu <166728538+sunflowersxu@users.noreply.github.com> Co-authored-by: liqun Fu <liqfu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Aug 26, 2024
### Description onnx#6215 --------- Signed-off-by: liqunfu <liqun.fu@microsoft.com> Signed-off-by: liqun Fu <liqun.fu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description onnx#6215 --------- Signed-off-by: liqunfu <liqun.fu@microsoft.com> Signed-off-by: liqun Fu <liqun.fu@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6215