Fix a few crashes while running shape inference #6195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6195 +/- ##
==========================================
+ Coverage 56.95% 57.28% +0.32%
==========================================
Files 506 506
Lines 30467 31064 +597
Branches 4592 4619 +27
==========================================
+ Hits 17353 17795 +442
- Misses 12285 12446 +161
+ Partials 829 823 -6 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Jun 20, 2024
gramalingam
reviewed
Jun 20, 2024
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
linkerzhang
reviewed
Jun 24, 2024
gramalingam
approved these changes
Jul 3, 2024
liqunfu
added a commit
to microsoft/onnxruntime
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
snnn
pushed a commit
to microsoft/onnxruntime
that referenced
this pull request
Jul 27, 2024
…:convPoolShapeInference (#21507) ### Description onnx 1.16.2 is not available before ort 1.19.0 code freeze. Thus pick the needed change as patch
rohan11235813
pushed a commit
to quadric-io/onnxruntime
that referenced
this pull request
Aug 19, 2025
…:convPoolShapeInference (#21507) ### Description onnx 1.16.2 is not available before ort 1.19.0 code freeze. Thus pick the needed change as patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6186, #6185, #6180, #6187.
It also improves the error messages to let users know where something is going wrong.