Skip to content

Rename test name with duplicated names, add logic to check it does not happen again #6194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2024
Merged

Rename test name with duplicated names, add logic to check it does not happen again #6194

merged 3 commits into from
Jun 20, 2024

Conversation

xadupre
Copy link
Contributor

@xadupre xadupre commented Jun 20, 2024

Replaces #6189 and checks this bug does not happen somewhere else.

@xadupre
Rename test name with duplicated names, add logic to check it does no…
149e617 
…t happen again

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre requested a review from a team as a code owner June 20, 2024 09:08
@xadupre xadupre mentioned this pull request Jun 20, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.10%. Comparing base (83194ed) to head (2529d29).
Report is 51 commits behind head on main.

Files Patch % Lines
onnx/backend/test/case/node/__init__.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6194      +/-   ##
==========================================
+ Coverage   56.95%   57.10%   +0.15%     
==========================================
  Files         506      506              
  Lines       30467    30978     +511     
  Branches     4592     4604      +12     
==========================================
+ Hits        17353    17691     +338     
- Misses      12285    12462     +177     
+ Partials      829      825       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xadupre added 2 commits June 20, 2024 13:17
@xadupre
rename test with test_
ff8b877 
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre
lint
2529d29 
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@gramalingam gramalingam added this pull request to the merge queue Jun 20, 2024
Merged via the queue into onnx:main with commit 159fa47 Jun 20, 2024
@xadupre xadupre self-assigned this Jun 21, 2024
andife pushed a commit to andife/onnx that referenced this pull request Jul 20, 2024
@xadupre @andife
Rename test name with duplicated names, add logic to check it does no…
d6079d5 
…t happen again (onnx#6194)

Replaces onnx#6189 and checks this bug does not happen somewhere else.

---------

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@xadupre @linshokaku
Rename test name with duplicated names, add logic to check it does no…
f7b6982 
…t happen again (onnx#6194)

Replaces onnx#6189 and checks this bug does not happen somewhere else.

---------

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

Assignees

@xadupre xadupre

Labels
None yet
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xadupre @gramalingam