Fix wrong test name (causing test files of previous test with same name to be overwritten) #6189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me to be overwritten)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6189 +/- ##
==========================================
+ Coverage 56.95% 57.09% +0.14%
==========================================
Files 506 506
Lines 30467 30974 +507
Branches 4592 4603 +11
==========================================
+ Hits 17353 17686 +333
- Misses 12285 12464 +179
+ Partials 829 824 -5 ☔ View full report in Codecov by Sentry. |
gramalingam
previously approved these changes
Jun 19, 2024
|
Thanks for catching this. A couple of things are required: The DCO needs to be signed. The affected test-data needs to be generated and committed. |
|
I'm closing this PR, I replaced it #6194 because this issue happens on some other test case. I added some logic to detect it does not happen again. |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In test
empty_axes_input_noop, correct the name of the name as passed on toexpectfunctionMotivation and Context
The passed name was previously
test_reduce_sum_negative_axes_keepdims_random, which clashed with an earlier test with the same name, causing test files to be overwritten