Skip to content

Addition of group > 1 in test and in backend for ConvTranspose #6175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 17, 2024
Merged

Addition of group > 1 in test and in backend for ConvTranspose #6175

merged 9 commits into from
Jun 17, 2024

Conversation

xadupre
Copy link
Contributor

@xadupre xadupre commented Jun 13, 2024

Description

Replaces #5877 as the number of impacted files is too high to be reviewed.

xadupre added 3 commits June 13, 2024 12:36
@xadupre
update ConvTranspose
7fc1796 
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre
add test case
cf395b6 
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre
update doc
e04bac0 
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre requested a review from a team as a code owner June 13, 2024 10:40
@xadupre xadupre mentioned this pull request Jun 13, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes missing coverage. Please review.

Project coverage is 57.02%. Comparing base (83194ed) to head (e405f2f).
Report is 43 commits behind head on main.

Files Patch % Lines
onnx/backend/test/case/node/convtranspose.py 0.00% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6175      +/-   ##
==========================================
+ Coverage   56.95%   57.02%   +0.07%     
==========================================
  Files         506      506              
  Lines       30467    30978     +511     
  Branches     4592     4603      +11     
==========================================
+ Hits        17353    17666     +313     
- Misses      12285    12488     +203     
+ Partials      829      824       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 13, 2024
View reviewed changes
xadupre and others added 5 commits June 13, 2024 12:51
@xadupre
remove one unnecessary test
91aa550 
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre
Merge branch 'main' into group
9a61a76
@xadupre
lint
357d673 
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre
Merge branch 'group' of https://github.com/xadupre/onnx into group
141fbee
@xadupre
update ci
bae3a50 
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
@xadupre xadupre requested a review from a team as a code owner June 13, 2024 14:37
@justinchuby justinchuby changed the title addition of group > 1 in test and in backend, replaces 5877 Addition of group > 1 in test and in backend for ConvTranspose Jun 13, 2024
@justinchuby justinchuby added the topic: operator Issues related to ONNX operators label Jun 13, 2024
@xadupre xadupre enabled auto-merge June 14, 2024 07:56
@xadupre xadupre added this pull request to the merge queue Jun 17, 2024
Merged via the queue into onnx:main with commit 7934713 Jun 17, 2024
@xadupre xadupre deleted the group branch June 17, 2024 17:24
@xadupre xadupre self-assigned this Jun 21, 2024
andife pushed a commit to andife/onnx that referenced this pull request Jul 20, 2024
@xadupre @andife
Addition of group > 1 in test and in backend for ConvTranspose (onnx#…
7f9a3d4 
…6175)

### Description
Replaces onnx#5877 as the number of impacted files is too high to be
reviewed.

---------

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@xadupre @linshokaku
Addition of group > 1 in test and in backend for ConvTranspose (onnx#…
fccc136 
…6175)

### Description
Replaces onnx#5877 as the number of impacted files is too high to be
reviewed.

---------

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

@justinchuby justinchuby justinchuby approved these changes

Assignees

@xadupre xadupre

Labels
topic: operator Issues related to ONNX operators
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xadupre @gramalingam @justinchuby