Better name for Github Action and fix Windows build on CI #6173
Conversation
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6173 +/- ##
==========================================
+ Coverage 56.95% 57.05% +0.09%
==========================================
Files 506 506
Lines 30467 30941 +474
Branches 4592 4595 +3
==========================================
+ Hits 17353 17652 +299
- Misses 12285 12464 +179
+ Partials 829 825 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Directly calling setup.py is deprecated, so we probably shouldn't do it. Do we know why it behaves differently in py38/39? Did anything change for the pipelines (they used to work)?
Also - once we include all information in the names, complications arise when we want to tweak some options - the names will change and we will need to go into github settings and mark/unmark required checks. I wonder if it is a good idea to print these information as a step in the job?
I suggest keeping it for this PR. We can still fix it later. |
### Description As the title says. --------- Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
### Description As the title says. --------- Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Description
As the title says.