MacOS release action is failing. #6105
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liqunfu <liqun.fu@microsoft.com>
|
Does the change fix the error? |
This
We need the fix in order to build wheels to be published. Unless there is already wheels built, tested, and ready to upload to pypi, we need fix the issue this PR is targeting. Hopefully github team can the issue without this PR: actions/setup-python#855. |
no. the issue is with setup python: actions/setup-python#855. We need to first wait to see if github team has a solution to the original issue. We will then see if a PR is needed with the solution. |
I wouldn't hold my breath on a solution in the short term given at least Python 3.8 & 3.9 are built from sources with homebrew dependencies on macOS x86_64. My 2 cents, either:
The first one comes with no risk in the short term (moving away from macOS-12 will need to happen at some point). |
|
Is it possible to create x64 universal builds from arm64? |
Yes, it's possible to create universal2 builds from macOS arm64. I opened #6117 |
|
#6117 fixes it |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 1, 2024
### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close #6105 --------- Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
May 2, 2024
…x#6117) ### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close onnx#6105 --------- Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: isdanni <leedanni@gmail.com>
cjvolzka
pushed a commit
that referenced
this pull request
May 2, 2024
### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close #6105 --------- Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 1529880)
cjvolzka
pushed a commit
that referenced
this pull request
May 2, 2024
### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close #6105 --------- Signed-off-by: Matthieu Darbois <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 1529880)
cjvolzka
pushed a commit
that referenced
this pull request
May 2, 2024
### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close #6105 --------- Signed-off-by: Matthieu Darbois <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> (cherry picked from commit 1529880)
justinchuby
added a commit
that referenced
this pull request
May 4, 2024
### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close #6105 --------- Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
May 6, 2024
…x#6117) ### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close onnx#6105 --------- Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: isdanni <leedanni@gmail.com>
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
Jun 6, 2024
…x#6117) ### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close onnx#6105 --------- Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
…x#6117) ### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close onnx#6105 --------- Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
…x#6117) ### Description Build and test macOS universal2 wheels on macOS arm64 Removes x86_64 wheels. ### Motivation and Context `macos-latest` runners moved to macOS 14 running on arm64 hardware. This is breaking the macOS release pipeline. This PR rewrites the macOS release pipeline in 2 parts: - Build universal2 wheels on `macos-latest` - Test both arm64 & x86_64 parts of the universal2 wheel on `macos-latest` The x86_64 wheels have been removed as the universal2 ones can be used on x86_64. close onnx#6105 --------- Signed-off-by: mayeut <mayeut@users.noreply.github.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(actions/setup-python#855)
Motivation and Context