Skip to content

Conversation

justinchuby
Copy link
Member

@justinchuby justinchuby commented Apr 10, 2024

Migrate CI to use Github Actions. Update Google Test to a newer version (some version in 2022). The latest commit has errors I don't know how to fix.

Use FetchContent instead of ExternalProject to bring in googletest according to its documentation https://google.github.io/googletest/quickstart-cmake.html

Fixes #6074 Fixes #6073

@justinchuby justinchuby requested a review from a team as a code owner April 10, 2024 22:20
@justinchuby justinchuby marked this pull request as draft April 10, 2024 22:20
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.04%. Comparing base (4128a09) to head (b15f3bb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6075      +/-   ##
==========================================
+ Coverage   56.97%   57.04%   +0.06%     
==========================================
  Files         506      506              
  Lines       30483    30483              
  Branches     4593     4593              
==========================================
+ Hits        17369    17388      +19     
+ Misses      12285    12269      -16     
+ Partials      829      826       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby force-pushed the justinchu/github-actions branch from 4016fbd to fa61625 Compare April 11, 2024 04:03
@justinchuby justinchuby added the run release CIs Use this label to trigger release tests in CI label Apr 11, 2024
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby force-pushed the justinchu/github-actions branch from 4a79f63 to 025b650 Compare April 11, 2024 16:48
@justinchuby justinchuby marked this pull request as ready for review April 11, 2024 16:51
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby requested a review from gramalingam April 11, 2024 16:53
@justinchuby justinchuby enabled auto-merge April 11, 2024 17:11
@justinchuby justinchuby added the topic: better engineering Improve engineering quality of the project label Apr 11, 2024
@gramalingam gramalingam disabled auto-merge April 12, 2024 16:01
@gramalingam
Copy link
Contributor

Will try closing and reopening this PR

@gramalingam gramalingam reopened this Apr 12, 2024
@gramalingam gramalingam enabled auto-merge April 12, 2024 16:03
@gramalingam gramalingam added this pull request to the merge queue Apr 12, 2024
Merged via the queue into onnx:main with commit 284b124 Apr 12, 2024
gramalingam pushed a commit to gramalingam/onnx that referenced this pull request Apr 12, 2024
Migrate CI to use Github Actions. Update Google Test to a newer version
(some version in 2022). The latest commit has errors I don't know how to
fix.

Use `FetchContent` instead of `ExternalProject` to bring in googletest
according to its documentation
https://google.github.io/googletest/quickstart-cmake.html

Fixes onnx#6074 Fixes
onnx#6073

---------

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam pushed a commit to gramalingam/onnx that referenced this pull request Apr 12, 2024
Migrate CI to use Github Actions. Update Google Test to a newer version
(some version in 2022). The latest commit has errors I don't know how to
fix.

Use `FetchContent` instead of `ExternalProject` to bring in googletest
according to its documentation
https://google.github.io/googletest/quickstart-cmake.html

Fixes onnx#6074 Fixes
onnx#6073

---------

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
cjvolzka pushed a commit that referenced this pull request May 9, 2024
Migrate CI to use Github Actions. Update Google Test to a newer version
(some version in 2022). The latest commit has errors I don't know how to
fix.

Use `FetchContent` instead of `ExternalProject` to bring in googletest
according to its documentation
https://google.github.io/googletest/quickstart-cmake.html

Fixes #6074 Fixes
#6073

---------

Signed-off-by: Justin Chu <justinchu@microsoft.com>
(cherry picked from commit 284b124)
cjvolzka pushed a commit that referenced this pull request May 9, 2024
Migrate CI to use Github Actions. Update Google Test to a newer version
(some version in 2022). The latest commit has errors I don't know how to
fix.

Use `FetchContent` instead of `ExternalProject` to bring in googletest
according to its documentation
https://google.github.io/googletest/quickstart-cmake.html

Fixes #6074 Fixes
#6073

---------

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
(cherry picked from commit 284b124)
@cjvolzka cjvolzka added this to the 1.16.1 milestone May 9, 2024
cjvolzka added a commit that referenced this pull request May 9, 2024
### Description
Check-pick commits from `main` into `rel-1.16.1` branch

### Motivation and Context
Fix 1.16.0 issues and enabled 1.16.1 builds by cherry-picking the
following PRs from `main` into the `1.16.1` branch

* Fixes since 1.16.0 release
    * #6049
    * #6048
    * #6080
    * #6122

* Update CI and Build to enable 1.16.1 builds
    * #6106
    * #6129
    * #6075
    * #6117

---------

Co-authored-by: liqun Fu <liqfu@microsoft.com>
Co-authored-by: G. Ramalingam <grama@microsoft.com>
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
gramalingam pushed a commit to gramalingam/onnx that referenced this pull request Jun 6, 2024
Migrate CI to use Github Actions. Update Google Test to a newer version
(some version in 2022). The latest commit has errors I don't know how to
fix.

Use `FetchContent` instead of `ExternalProject` to bring in googletest
according to its documentation
https://google.github.io/googletest/quickstart-cmake.html

Fixes onnx#6074 Fixes
onnx#6073

---------

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife pushed a commit to andife/onnx that referenced this pull request Jul 20, 2024
Migrate CI to use Github Actions. Update Google Test to a newer version
(some version in 2022). The latest commit has errors I don't know how to
fix.

Use `FetchContent` instead of `ExternalProject` to bring in googletest
according to its documentation
https://google.github.io/googletest/quickstart-cmake.html

Fixes onnx#6074 Fixes
onnx#6073

---------

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
Migrate CI to use Github Actions. Update Google Test to a newer version
(some version in 2022). The latest commit has errors I don't know how to
fix.

Use `FetchContent` instead of `ExternalProject` to bring in googletest
according to its documentation
https://google.github.io/googletest/quickstart-cmake.html

Fixes onnx#6074 Fixes
onnx#6073

---------

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run release CIs Use this label to trigger release tests in CI topic: better engineering Improve engineering quality of the project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Pause all PR merges Migrate CI pipelines from AzureDevOps to Github Actions
3 participants