Not to install cmake in pyproject.toml on Windows #6045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6045 +/- ##
=======================================
Coverage 56.95% 56.95%
=======================================
Files 506 506
Lines 30467 30467
Branches 4592 4592
=======================================
Hits 17353 17353
Misses 12285 12285
Partials 829 829 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Mar 28, 2024
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
### Description Current fix of onnx#5194 forces out system installed cmake. It forces to use a cmake installed via pyproject.toml in a python environment. The cmake in python environment fails on Windows - onnx.sln cannot be built with visual studio due to protobuf code generation error. This PR skip cmake install in pyproject.toml in Windows. It is better only include cmake in pyproject.toml if needed. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description Current fix of onnx#5194 forces out system installed cmake. It forces to use a cmake installed via pyproject.toml in a python environment. The cmake in python environment fails on Windows - onnx.sln cannot be built with visual studio due to protobuf code generation error. This PR skip cmake install in pyproject.toml in Windows. It is better only include cmake in pyproject.toml if needed. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> Signed-off-by: Liqun Fu <liqfu@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current fix of #5194 forces out system installed cmake. It forces to use a cmake installed via pyproject.toml in a python environment. The cmake in python environment fails on Windows - onnx.sln cannot be built with visual studio due to protobuf code generation error.
This PR skip cmake install in pyproject.toml in Windows. It is better only include cmake in pyproject.toml if needed.
Motivation and Context