Skip to content

Enable additional ruff rules #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 16, 2024
Merged

Enable additional ruff rules #6032

merged 7 commits into from
Apr 16, 2024

Conversation

justinchuby
Copy link
Member

Enable additional ruff rules and apply fixes

@justinchuby justinchuby requested review from a team as code owners March 24, 2024 16:36
@justinchuby justinchuby force-pushed the justinchu/more-ruff branch from ce20a17 to 489bdd3 Compare March 24, 2024 16:37
@justinchuby justinchuby marked this pull request as draft March 24, 2024 17:03
@justinchuby justinchuby force-pushed the justinchu/more-ruff branch from aaedef6 to fdbde82 Compare April 16, 2024 03:39
@justinchuby justinchuby marked this pull request as ready for review April 16, 2024 03:39
@justinchuby justinchuby force-pushed the justinchu/more-ruff branch from fdbde82 to 69fc0de Compare April 16, 2024 03:40
@justinchuby
Update pyproject
03c5d54 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Ruff fix
67337e1 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Fix more
a5133a4 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Add noqa
e8e5078 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
lint
21e328c 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby force-pushed the justinchu/more-ruff branch from 69fc0de to 21e328c Compare April 16, 2024 03:41
@justinchuby justinchuby added the run release CIs Use this label to trigger release tests in CI label Apr 16, 2024
@justinchuby justinchuby reopened this Apr 16, 2024
@justinchuby
Copy link
Member Author

@gramalingam

@justinchuby justinchuby added topic: better engineering Improve engineering quality of the project review needed: operators approvers Require reviews from members of operators-approvers labels Apr 16, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 37.23653% with 268 lines in your changes are missing coverage. Please review.

Project coverage is 57.03%. Comparing base (83194ed) to head (e6f9272).
Report is 16 commits behind head on main.

Files Patch % Lines
onnx/backend/test/report/coverage.py 0.00% 17 Missing ⚠️
onnx/hub.py 30.76% 8 Missing and 1 partial ⚠️
onnx/defs/gen_doc.py 0.00% 7 Missing ⚠️
onnx/backend/sample/ops/__init__.py 0.00% 4 Missing ⚠️
onnx/backend/test/case/node/loop.py 0.00% 4 Missing ⚠️
onnx/backend/test/stat_coverage.py 0.00% 4 Missing ⚠️
onnx/backend/test/case/model/__init__.py 0.00% 3 Missing ⚠️
onnx/backend/test/case/node/concat.py 0.00% 3 Missing ⚠️
onnx/backend/test/case/node/gru.py 0.00% 3 Missing ⚠️
onnx/backend/test/case/node/lstm.py 0.00% 3 Missing ⚠️
... and 201 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6032      +/-   ##
==========================================
+ Coverage   56.95%   57.03%   +0.08%     
==========================================
  Files         506      506              
  Lines       30467    30935     +468     
  Branches     4592     4592              
==========================================
+ Hits        17353    17645     +292     
- Misses      12285    12464     +179     
+ Partials      829      826       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
fix
b9c8718 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby added the auto update doc Generate md/proto files automatically using the CI pipeline label Apr 16, 2024
@justinchuby justinchuby reopened this Apr 16, 2024
@justinchuby @github-actions
CI:apply auto updated documentation/backend test data
e6f9272 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@justinchuby justinchuby removed the auto update doc Generate md/proto files automatically using the CI pipeline label Apr 16, 2024
@justinchuby justinchuby reopened this Apr 16, 2024
@justinchuby justinchuby enabled auto-merge April 16, 2024 04:14
@justinchuby justinchuby added this pull request to the merge queue Apr 16, 2024
Merged via the queue into onnx:main with commit c459890 Apr 16, 2024
@justinchuby justinchuby deleted the justinchu/more-ruff branch April 16, 2024 05:05
gramalingam pushed a commit to gramalingam/onnx that referenced this pull request Jun 6, 2024
@justinchuby @gramalingam
Enable additional ruff rules (onnx#6032)
2ad849c 
Enable additional ruff rules and apply fixes

---------

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
andife pushed a commit to andife/onnx that referenced this pull request Jul 20, 2024
@justinchuby @andife
Enable additional ruff rules (onnx#6032)
6a108a7 
Enable additional ruff rules and apply fixes

---------

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@justinchuby @linshokaku
Enable additional ruff rules (onnx#6032)
968adba 
Enable additional ruff rules and apply fixes

---------

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramalingam gramalingam gramalingam approved these changes

Assignees
No one assigned
Labels
review needed: operators approvers Require reviews from members of operators-approvers run release CIs Use this label to trigger release tests in CI topic: better engineering Improve engineering quality of the project
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinchuby @gramalingam