Skip to content

Update error messages for NegativeLogLikelihoodLoss inference function #6021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

justinchuby
Copy link
Member

Description

Add the invalid shape information in errors message of NegativeLogLikelihoodLoss's inference function.

Motivation and Context

Better errors

@justinchuby justinchuby requested a review from a team as a code owner March 14, 2024 00:25
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby force-pushed the justinchu/nll-loss-inference branch from fbf9cf6 to 01fba2c Compare March 14, 2024 00:29
@justinchuby justinchuby added this to the 1.17 milestone Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (6eb45c0) to head (651b66b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6021   +/-   ##
=======================================
  Coverage   56.81%   56.81%           
=======================================
  Files         506      506           
  Lines       30370    30370           
  Branches     4592     4592           
=======================================
  Hits        17256    17256           
  Misses      12285    12285           
  Partials      829      829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added the review needed: operators approvers Require reviews from members of operators-approvers label Mar 14, 2024
@justinchuby justinchuby changed the title Update inference messages for NegativeLogLikelihoodLoss Update error messages for NegativeLogLikelihoodLoss inference function Mar 14, 2024
@justinchuby justinchuby removed the review needed: operators approvers Require reviews from members of operators-approvers label Mar 18, 2024
@justinchuby justinchuby added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024
@justinchuby justinchuby added this pull request to the merge queue Mar 18, 2024
Merged via the queue into onnx:main with commit 17dbae7 Mar 18, 2024
@justinchuby justinchuby deleted the justinchu/nll-loss-inference branch March 18, 2024 19:47
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
onnx#6021)

### Description
Add the invalid shape information in errors message of
NegativeLogLikelihoodLoss's inference function.

### Motivation and Context
Better errors

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants