Remove deprecated mapping constants #6914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6914 +/- ##
==========================================
- Coverage 56.31% 56.31% -0.01%
==========================================
Files 509 509
Lines 32607 32590 -17
Branches 3099 3097 -2
==========================================
- Hits 18364 18354 -10
+ Misses 13385 13378 -7
Partials 858 858 ☔ View full report in Codecov by Sentry. |
justinchuby
commented
Apr 21, 2025
justinchuby
commented
Apr 21, 2025
6f2018c to
0c9a95a
Compare
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Justin Chu <justinchu@microsoft.com>
0c9a95a to
6e75258
Compare
|
@justinchuby: Where was it "scheduled"? |
andife
approved these changes
Apr 23, 2025
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
May 19, 2025
Remove the deprecated mappings as scheduled. Fixes onnx#4554 --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Justin Chu <justinchu@microsoft.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> Signed-off-by: gramalingam <grama@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deprecated mappings as scheduled.
Fixes #4554