Harmonize protobuf versions by upgrading to a minimum protobuf version of 25.1 and fix CI error #6725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22103ab to
8677d8f
Compare
5f1e904 to
3a23223
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6725 +/- ##
=======================================
Coverage 56.45% 56.45%
=======================================
Files 509 509
Lines 32515 32515
Branches 3057 3057
=======================================
Hits 18356 18356
Misses 13334 13334
Partials 825 825 ☔ View full report in Codecov by Sentry. |
ed695c2 to
224a1e3
Compare
|
@andife @justinchuby Seems that it works. The lining failures are unrelated. |
|
The release pipelines must be triggered manually with the label “run release CIs”. As I understand it, we do not currently have tests for all the cases we want? |
224a1e3 to
71d31d5
Compare
a55eef7 to
4dbef00
Compare
094ae12 to
625fb2c
Compare
justinchuby
reviewed
Feb 28, 2025
|
I think this looks good. @andife what do yo think |
I also think it should fit. |
|
What title is more suitable? |
According to my understanding the following: "Harmonize protobuf versions by upgrading to a minimum protobuf version of 25.1 and fix CI error" We had 21.12/protobuf-cpp-3.21.12.tar.gz before |
andife
approved these changes
Feb 28, 2025
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
justinchuby
reviewed
Mar 3, 2025
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
andife
approved these changes
Mar 3, 2025
justinchuby
reviewed
Mar 3, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix CI errors for using Protobuf 4.25.1 .
Motivation and Context