Skip to content

Format rotary embedding documentation #6717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2025
Merged

Format rotary embedding documentation #6717

merged 5 commits into from
Feb 20, 2025

Conversation

justinchuby
Copy link
Member

@justinchuby justinchuby commented Feb 20, 2025

Format rotary embedding documentation for proper rendering.

cc @gramalingam

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby requested a review from a team as a code owner February 20, 2025 19:17
Copy link
Contributor

@shubhambhokare1 shubhambhokare1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added this to the 1.18 milestone Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.21%. Comparing base (783ed42) to head (8c12f6d).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6717   +/-   ##
=======================================
  Coverage   57.21%   57.21%           
=======================================
  Files         505      505           
  Lines       31832    31832           
  Branches     3031     3031           
=======================================
  Hits        18213    18213           
  Misses      12797    12797           
  Partials      822      822           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added the auto update doc Generate md/proto files automatically using the CI pipeline label Feb 20, 2025
auto-merge was automatically disabled February 20, 2025 20:00

Pull request was closed

@justinchuby justinchuby reopened this Feb 20, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby requested a review from a team as a code owner February 20, 2025 20:22
@justinchuby justinchuby reopened this Feb 20, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby removed the auto update doc Generate md/proto files automatically using the CI pipeline label Feb 20, 2025
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 556ac80 Feb 20, 2025
37 of 38 checks passed
@justinchuby justinchuby deleted the justinchu/rotary branch February 20, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants