Skip to content

Remove onnxruntime tests #6709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Remove onnxruntime tests #6709

merged 1 commit into from
Feb 18, 2025

Conversation

justinchuby
Copy link
Member

@justinchuby justinchuby commented Feb 15, 2025

Description

Remove onnxruntime node tests from the onnx package.

Additionally removed outdated tests.

Motivation and Context

The tests here are always one version older than the ort version in development, making the upkeep of the ort tests and addition of new tests cumbersome. These tests should run in the onnxruntime repository instead.

The only node tests we should keep are those for the reference evaluator.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby requested a review from a team as a code owner February 15, 2025 17:11
@justinchuby justinchuby added this to the 1.18 milestone Feb 15, 2025
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.60%. Comparing base (0425433) to head (53331fd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6709      +/-   ##
==========================================
+ Coverage   57.50%   57.60%   +0.10%     
==========================================
  Files         507      503       -4     
  Lines       31636    31489     -147     
  Branches     3048     3025      -23     
==========================================
- Hits        18191    18139      -52     
+ Misses      12618    12528      -90     
+ Partials      827      822       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby justinchuby added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 657cbbe Feb 18, 2025
45 checks passed
@justinchuby justinchuby deleted the justinchu/remove-ort-tests branch February 18, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants