Fix Pad operator example in Python API docs (correct attribute usage) #6702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dd004e to
f98a722
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6702 +/- ##
=======================================
Coverage 57.50% 57.50%
=======================================
Files 507 507
Lines 31636 31636
Branches 3048 3048
=======================================
Hits 18191 18191
Misses 12618 12618
Partials 827 827 ☔ View full report in Codecov by Sentry. |
Signed-off-by: vivek kolasani kolasaniv1996@gmail.com Signed-off-by: EC2 Default User <ec2-user@ip-172-31-73-195.ec2.internal>
f98a722 to
80d062e
Compare
|
Thanks, please merge when you get a chance |
seungwoo-ji-03
pushed a commit
to seungwoo-ji-03/onnx
that referenced
this pull request
Feb 17, 2025
…onnx#6702) ### Description This PR corrects the `Pad` operator example in the Python API documentation. The original code incorrectly treated `value` as an input tensor and used an invalid `pads` data type. The updated example sets `value` as a float attribute, uses `INT64` for `pads`, and includes OPSET 11 compatibility. ### Motivation and Context The incorrect example could lead users to create invalid ONNX models. This fix ensures the documentation reflects proper usage of the `Pad` operator and ONNX standards, improving the developer experience. Signed-off-by: vivek kolasani kolasaniv1996@gmail.com Signed-off-by: EC2 Default User <ec2-user@ip-172-31-73-195.ec2.internal> Co-authored-by: EC2 Default User <ec2-user@ip-172-31-73-195.ec2.internal> Signed-off-by: seungwoo-ji <seungwoo.ji@nuvilab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the
Padoperator example in the Python API documentation. The original code incorrectly treatedvalueas an input tensor and used an invalidpadsdata type. The updated example setsvalueas a float attribute, usesINT64forpads, and includes OPSET 11 compatibility.Motivation and Context
The incorrect example could lead users to create invalid ONNX models. This fix ensures the documentation reflects proper usage of the
Padoperator and ONNX standards, improving the developer experience.