Add cmake dependency only when system cmake is not available (backend version) #6643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Do you expect |
justinchuby
reviewed
Jan 19, 2025
The backend is standardized per PEP 517 (and followup PEPs), so |
|
When you get a chance, could you also signoff the commits following https://github.com/onnx/onnx/pull/6643/checks?check_run_id=35781036009 ? Thanks! |
justinchuby
approved these changes
Jan 19, 2025
Yeah, just noticed I didn't do that. Signoff will be there with the update. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6643 +/- ##
=======================================
Coverage 57.46% 57.46%
=======================================
Files 507 507
Lines 31584 31584
Branches 3046 3046
=======================================
Hits 18151 18151
Misses 12607 12607
Partials 826 826 ☔ View full report in Codecov by Sentry. |
Instead of unconditionally pulling `cmake` PyPI package in, check whether `cmake` is available first and add the dependency only when it is not available. This is the same approach as used by the `scikit-build-core` package, and it improves portability, especially given that CMake frequently requires downstream patching to work. In this version of the patch, I've created a minimal PEP517 build backend that inherits the functions provided by setuptools, and adds the CMake dependency when necessary. This avoids using deprecated setuptools `setup_requires` argument, and it avoids adding CMake dependency when building source distributions. Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
Updated. Added an explanatory docstring, and fixed ruff errors. |
|
Thank you! |
andife
pushed a commit
that referenced
this pull request
Jan 25, 2025
… version) (#6643) ### Description Instead of unconditionally pulling `cmake` PyPI package in, check whether `cmake` is available first and add the dependency only when it is not available. This is the same approach as used by the `scikit-build-core` package, and it improves portability, especially given that CMake frequently requires downstream patching to work. In this version of the patch, I've created a minimal PEP517 build backend that inherits the functions provided by setuptools, and adds the CMake dependency when necessary. This avoids using deprecated setuptools `setup_requires` argument, and it avoids adding CMake dependency when building source distributions. ### Motivation and Context Same as #6642, except using PEP517 backend instead of deprecated `setup_requires`. Signed-off-by: Michał Górny <mgorny@gentoo.org> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
seungwoo-ji-03
pushed a commit
to seungwoo-ji-03/onnx
that referenced
this pull request
Feb 17, 2025
… version) (onnx#6643) ### Description Instead of unconditionally pulling `cmake` PyPI package in, check whether `cmake` is available first and add the dependency only when it is not available. This is the same approach as used by the `scikit-build-core` package, and it improves portability, especially given that CMake frequently requires downstream patching to work. In this version of the patch, I've created a minimal PEP517 build backend that inherits the functions provided by setuptools, and adds the CMake dependency when necessary. This avoids using deprecated setuptools `setup_requires` argument, and it avoids adding CMake dependency when building source distributions. ### Motivation and Context Same as onnx#6642, except using PEP517 backend instead of deprecated `setup_requires`. Signed-off-by: Michał Górny <mgorny@gentoo.org> Signed-off-by: seungwoo-ji <seungwoo.ji@nuvilab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of unconditionally pulling
cmakePyPI package in, check whethercmakeis available first and add the dependency only when it is not available. This is the same approach as used by thescikit-build-corepackage, and it improves portability, especially given that CMake frequently requires downstream patching to work.In this version of the patch, I've created a minimal PEP517 build backend that inherits the functions provided by setuptools, and adds the CMake dependency when necessary. This avoids using deprecated setuptools
setup_requiresargument, and it avoids adding CMake dependency when building source distributions.Motivation and Context
Same as #6642, except using PEP517 backend instead of deprecated
setup_requires.