Remove struct and leverage ml_dtypes in helper tests #6631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6631 +/- ##
==========================================
+ Coverage 57.35% 57.43% +0.08%
==========================================
Files 507 507
Lines 31639 31611 -28
Branches 3063 3058 -5
==========================================
+ Hits 18145 18157 +12
+ Misses 12645 12610 -35
+ Partials 849 844 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
gramalingam
approved these changes
Jan 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
The change in #6631 mistakenly removed a skip Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
andife
pushed a commit
that referenced
this pull request
Jan 25, 2025
Remove the use of struct and leverage ml_dtypes to clean up helper tests. This should unblock #6621 --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
andife
pushed a commit
that referenced
this pull request
Jan 25, 2025
The change in #6631 mistakenly removed a skip Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
seungwoo-ji-03
pushed a commit
to seungwoo-ji-03/onnx
that referenced
this pull request
Feb 17, 2025
Remove the use of struct and leverage ml_dtypes to clean up helper tests. This should unblock onnx#6621 --------- Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: seungwoo-ji <seungwoo.ji@nuvilab.com>
seungwoo-ji-03
pushed a commit
to seungwoo-ji-03/onnx
that referenced
this pull request
Feb 17, 2025
The change in onnx#6631 mistakenly removed a skip Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: seungwoo-ji <seungwoo.ji@nuvilab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of struct and leverage ml_dtypes to clean up helper tests. This should unblock #6621