Fix reference implementation for TopK #6593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: neNasko1 <nasko119@gmail.com>
Signed-off-by: neNasko1 <nasko119@gmail.com>
Signed-off-by: neNasko1 <nasko119@gmail.com>
a27d2eb to
09e6c3c
Compare
Signed-off-by: neNasko1 <nasko119@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6593 +/- ##
==========================================
- Coverage 57.40% 57.35% -0.06%
==========================================
Files 507 507
Lines 31574 31609 +35
Branches 3062 3062
==========================================
+ Hits 18126 18128 +2
- Misses 12599 12633 +34
+ Partials 849 848 -1 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Dec 31, 2024
|
Thanks! cc @xadupre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes problems in the reference implementation of TopK in the following cases by rewriting the tiebreaker mechanism and unifying logic for all cases.
Motivation and Context
The ONNX documentation states:
This was not the case currently as the
flipafter theargsortchanges the order of the same-valued elements.Additionally the logic around 2d shaped inputs introduces a bug for unsigned inputs as the negation overflowed.
This mismatch between the reference implementation and
onnxruntimewas found by running the array-api test suite through ndonnx on both.