Skip to content

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Oct 27, 2024

Description

In building Pytorch or other packages, it's sometimes desirable to avoid the influence of old protobuf from the build host and force linking to local build. A new option ONNX_BUILD_CUSTOM_PROTOBUF was added for this purpose.

Motivation and Context

@cyyever cyyever requested a review from a team as a code owner October 27, 2024 03:14
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.21%. Comparing base (9eb9eab) to head (b1a78be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6495   +/-   ##
=======================================
  Coverage   57.21%   57.21%           
=======================================
  Files         505      505           
  Lines       31832    31832           
  Branches     3031     3031           
=======================================
  Hits        18213    18213           
  Misses      12797    12797           
  Partials      822      822           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyyever cyyever force-pushed the ONNX_CUSTOM_PROTOBUF branch 4 times, most recently from 20d94ff to 3073557 Compare October 27, 2024 03:25
@cyyever cyyever force-pushed the ONNX_CUSTOM_PROTOBUF branch from 3073557 to 4024746 Compare November 17, 2024 01:11
@justinchuby justinchuby added the topic: build Issues related to ONNX builds and packages label Nov 17, 2024
@justinchuby justinchuby temporarily deployed to testpypi_onnxweekly November 17, 2024 03:43 — with GitHub Actions Inactive
@justinchuby justinchuby requested a review from liqunfu November 17, 2024 03:43
@cyyever cyyever force-pushed the ONNX_CUSTOM_PROTOBUF branch from be866cb to af29808 Compare February 21, 2025 10:15
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever cyyever force-pushed the ONNX_CUSTOM_PROTOBUF branch from a8db735 to b1a78be Compare February 21, 2025 10:18
Copy link
Member

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@justinchuby justinchuby added the release notes Important changes to call out in release notes label Feb 21, 2025
@justinchuby justinchuby added this to the 1.18 milestone Feb 21, 2025
@justinchuby justinchuby added this pull request to the merge queue Feb 21, 2025
Merged via the queue into onnx:main with commit c80260f Feb 21, 2025
46 checks passed
@cyyever cyyever deleted the ONNX_CUSTOM_PROTOBUF branch April 10, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes Important changes to call out in release notes topic: build Issues related to ONNX builds and packages
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants