-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Move to using protogen's .pyi file generator #6462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
da311d0
to
317c0c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6462 +/- ##
=======================================
Coverage 57.36% 57.36%
=======================================
Files 507 507
Lines 31502 31502
Branches 3544 3544
=======================================
Hits 18072 18072
Misses 12581 12581
Partials 849 849 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
ab5c12c
to
8fdd0d5
Compare
justinchuby
commented
Oct 15, 2024
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@xadupre could you approve? Thanks! |
gramalingam
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run release CIs
Use this label to trigger release tests in CI
topic: better engineering
Improve engineering quality of the project
topic: build
Issues related to ONNX builds and packages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #6096
Fixes #6034 Fixes #6406