Skip to content

Conversation

justinchuby
Copy link
Member

@justinchuby justinchuby commented Oct 15, 2024

Continuation of #6096

Fixes #6034 Fixes #6406

@justinchuby justinchuby requested a review from a team as a code owner October 15, 2024 16:56
justinchuby and others added 2 commits October 15, 2024 16:58
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby changed the title Move to using protogen's .pyi file generator (#6096) Move to using protogen's .pyi file generator Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.36%. Comparing base (ce62671) to head (b8fa026).
Report is 269 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6462   +/-   ##
=======================================
  Coverage   57.36%   57.36%           
=======================================
  Files         507      507           
  Lines       31502    31502           
  Branches     3544     3544           
=======================================
  Hits        18072    18072           
  Misses      12581    12581           
  Partials      849      849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added run release CIs Use this label to trigger release tests in CI topic: better engineering Improve engineering quality of the project labels Oct 15, 2024
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Oct 15, 2024
@justinchuby justinchuby added run release CIs Use this label to trigger release tests in CI and removed run release CIs Use this label to trigger release tests in CI labels Oct 27, 2024
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby requested a review from xadupre October 30, 2024 03:31
@justinchuby
Copy link
Member Author

@xadupre could you approve? Thanks!

@justinchuby justinchuby enabled auto-merge October 30, 2024 04:09
@justinchuby justinchuby added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 69ddf6c Nov 4, 2024
34 checks passed
@justinchuby justinchuby deleted the justinchu/pyi branch November 4, 2024 19:19
@ramkrishna2910 ramkrishna2910 added the topic: build Issues related to ONNX builds and packages label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run release CIs Use this label to trigger release tests in CI topic: better engineering Improve engineering quality of the project topic: build Issues related to ONNX builds and packages
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ONNX Windows build relies on MS Store python, fails with official python launcher [Feature request] Use protobuf's generator to generate pyi stubs
4 participants