Add Rotary Embedding op to ONNX opset 23 #6461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6461 +/- ##
==========================================
- Coverage 57.25% 57.20% -0.06%
==========================================
Files 503 505 +2
Lines 31681 31823 +142
Branches 3025 3031 +6
==========================================
+ Hits 18139 18204 +65
- Misses 12720 12797 +77
Partials 822 822 ☔ View full report in Codecov by Sentry. |
xadupre
reviewed
Oct 15, 2024
xadupre
reviewed
Oct 15, 2024
gramalingam
reviewed
Oct 15, 2024
gramalingam
reviewed
Oct 15, 2024
gramalingam
reviewed
Oct 15, 2024
shubhambhokare1
commented
Oct 15, 2024
gramalingam
reviewed
Oct 16, 2024
gramalingam
reviewed
Oct 16, 2024
gramalingam
reviewed
Oct 16, 2024
gramalingam
reviewed
Oct 16, 2024
gramalingam
reviewed
Oct 16, 2024
gramalingam
reviewed
Oct 16, 2024
gramalingam
reviewed
Oct 16, 2024
gramalingam
reviewed
Oct 16, 2024
gramalingam
reviewed
Oct 16, 2024
gramalingam
reviewed
Oct 19, 2024
gramalingam
reviewed
Oct 19, 2024
gramalingam
reviewed
Oct 22, 2024
gramalingam
reviewed
Oct 22, 2024
justinchuby
reviewed
Oct 28, 2024
justinchuby
reviewed
Oct 28, 2024
5a38a0c to
3761433
Compare
gramalingam
approved these changes
Feb 15, 2025
56cac19 to
95b522f
Compare
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
Signed-off-by: shubhambhokare1 <shubhambhokare@gmail.com>
a702c74 to
c566651
Compare
Comment on lines
+2910
to
+2912
| ONNX_OPERATOR_SET_SCHEMA( | ||
| RotaryEmbedding, | ||
| 23, |
Check notice
Code scanning / CodeQL
Unused static variable Note
5245ae8 to
93e3cc5
Compare
|
I am merging this PR because it seems to be in an approved state. Please feel free to create follow up comments/patches if there are anything un-addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the following key LLM ops to the ONNX standard: RotaryEmbedding
Motivation and Context
Standardize Operators that are showing up in key LLM models.