Separate the infer_shapes option from the check_model option #6441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Po-Chu Hsu <tonypottera@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6441 +/- ##
=======================================
Coverage 57.25% 57.25%
=======================================
Files 507 507
Lines 31433 31433
Branches 4690 4690
=======================================
Hits 17997 17997
Misses 12581 12581
Partials 855 855 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate the
infer_shapesoption from thecheck_modeloption.Whether to
infer_shapesor not should be controlled independently.Motivation and Context
The
check_modelcheck was applied toinfer_shapesin #6344.However, for some use cases like issue #6368,
infer_shapesis necessary but it cannot passcheck_modelbecause the output node shape is missing.Adding an empty dimension like PR #6437 doesn't work since
onnxruntime.InferenceSessiontreats an empty dimension as a dimension.