Support models larger than 2GB #6438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Po-Chu Hsu <tonypottera@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6438 +/- ##
==========================================
- Coverage 57.26% 57.24% -0.02%
==========================================
Files 507 507
Lines 31432 31438 +6
Branches 3540 3542 +2
==========================================
Hits 17998 17998
- Misses 12590 12594 +4
- Partials 844 846 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Po-Chu Hsu <tonypottera@gmail.com>
xadupre
reviewed
Oct 10, 2024
xadupre
reviewed
Oct 10, 2024
Signed-off-by: Po-Chu Hsu <tonypottera@gmail.com>
justinchuby
reviewed
Oct 10, 2024
justinchuby
reviewed
Oct 10, 2024
Signed-off-by: Po-Chu Hsu <tonypottera@gmail.com>
Signed-off-by: Po-Chu Hsu <tonypottera@gmail.com>
justinchuby
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
infer_shapes_pathorinfer_shapes.save_as_external_dataononnx.save.Note that if
save_as_external_data=False, the followingcheck_modelmay fail.Motivation and Context
Current
extract_modelfunction does not support models larger than 2GB.For example, issue #6368 is caused by large models like an UNet.
This PR improves the existing function by checking the size of the model.