Skip to content

Conversation

justinchuby
Copy link
Member

@justinchuby justinchuby commented Oct 9, 2024

Description

  • Clarify that static optionals are available to all IR versions
  • Improve wording.

Motivation and Context

Spec clarification.

- Clarify that static optionals are available to all IR versions

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added the topic: spec clarification Clarification of the ONNX spec needed label Oct 9, 2024
@justinchuby justinchuby requested a review from a team as a code owner October 9, 2024 01:14
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.25%. Comparing base (d7fbf2b) to head (f5b10bc).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6435   +/-   ##
=======================================
  Coverage   57.25%   57.25%           
=======================================
  Files         507      507           
  Lines       31433    31433           
  Branches     4690     4690           
=======================================
  Hits        17997    17997           
  Misses      12581    12581           
  Partials      855      855           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gramalingam gramalingam added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit e647215 Oct 10, 2024
33 checks passed
@gramalingam gramalingam deleted the justinchu/static-optional-spec branch October 10, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: spec clarification Clarification of the ONNX spec needed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants