Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.41%. Comparing base (c0c18d0) to head (47c4b70).
Report is 231 commits behind head on main.

@@           Coverage Diff            @@
##             main    #6434    +/-   ##
========================================
  Coverage   57.41%   57.41%            
========================================
  Files         507      507            
  Lines       31538    31538            
  Branches     3549     3063   -486     
========================================
  Hits        18106    18106            
  Misses      12583    12583            
  Partials      849      849            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

After @gramalingam comment in #6298, I would still keep version 3.8. Pytorch currently still allows this. (When we release maybe every 3 months, which would be end of December we could reevaluate that again? I wonder if we need new version faster because of the windows build problems?)

But I am also open to removing it. Just don't see the need yet.

(Possibly it will come very soon, when some dependencies stop support, and it would mean an increased effort for us to support python 3.8)

PyTorch has dropped 3.8 for the up coming 2.6 release. That would be similar timing when we release 1.18 so I think that’s ok.

The https://github.com/pytorch/pytorch/blob/main/RELEASE.md#release-compatibility-matrix and release https://github.com/pytorch/pytorch/blob/main/RELEASE.md#release-compatibility-matrix looks nice.

In my opinion we should have something like that publicly available.

From my experience with Onnx, a release every 4 months might be realistic?

Now that pytorch and onnxruntime have discontinued support, I can well imagine removing 3.8. Now that we have added 3.13, this would also reduce CI runtimes.

@xadupre @gramalingam @justinchuby