Update op_pool_common.py, add missing "| None" #6421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example onnx/backend/test/case/node/averagepool.py uses pads = None Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #6421 +/- ##
=======================================
Coverage 57.22% 57.22%
=======================================
Files 507 507
Lines 31411 31411
Branches 4690 4690
=======================================
Hits 17975 17975
+ Misses 12581 12580 -1
- Partials 855 856 +1 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Oct 3, 2024
|
"|None" is CPython3.10+ syntax, should we use typing.Optional[Sequence[int]] for lower CPython versions? |
|
from future import annotations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example
onnx/backend/test/case/node/averagepool.py
uses
pads = None
Description
Motivation and Context