Skip to content

Remove proto generation step in test CIs #5344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2023
Merged

Remove proto generation step in test CIs #5344

merged 3 commits into from
Jun 20, 2023

Conversation

justinchuby
Copy link
Member

Description

Remove proto generation step in test CIs

Motivation and Context

They are tested already by https://github.com/onnx/onnx/blob/3e8a344785e9e1fe9260c3691f8c1daca7572024/.github/workflows/lint.yml

@justinchuby
Remove proto generation step in test CIs
97f959c 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby requested a review from a team as a code owner June 20, 2023 03:21
@justinchuby justinchuby requested a review from jcwchen June 20, 2023 03:21
jcwchen
jcwchen reviewed Jun 20, 2023
View reviewed changes
@jcwchen jcwchen added the module: CI pipelines Issues related to the CI pipeline label Jun 20, 2023
@jcwchen jcwchen added the topic: code style Issues related to coding style or the linter label Jun 20, 2023
@jcwchen jcwchen enabled auto-merge (squash) June 20, 2023 16:01
@jcwchen jcwchen merged commit 2843c9e into onnx:main Jun 20, 2023
@jcwchen jcwchen mentioned this pull request Jun 26, 2023
Merged
jcwchen added a commit that referenced this pull request Jun 29, 2023
@jcwchen
Ensure Lint CI catch documentation difference error (#5367)
e131980 
### Description
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md


### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
xadupre pushed a commit to xadupre/onnx that referenced this pull request Jul 4, 2023
@jcwchen @xadupre
Ensure Lint CI catch documentation difference error (onnx#5367)
b988e15 
### Description
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
onnx#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
xadupre pushed a commit to xadupre/onnx that referenced this pull request Jul 4, 2023
@jcwchen @xadupre
Ensure Lint CI catch documentation difference error (onnx#5367)
a706371 
### Description
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
onnx#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 15, 2023
@jcwchen @adityagoel4512
Ensure Lint CI catch documentation difference error (onnx#5367)
a7b953f 
### Description
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
onnx#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@justinchuby @adityagoel4512
Remove proto generation step in test CIs (onnx#5344)
03f515e 
### Description

Remove proto generation step in test CIs

### Motivation and Context

They are tested already by
https://github.com/onnx/onnx/blob/3e8a344785e9e1fe9260c3691f8c1daca7572024/.github/workflows/lint.yml

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@jcwchen @adityagoel4512
Ensure Lint CI catch documentation difference error (onnx#5367)
c3bc5ab 
### Description
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
onnx#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@jcwchen @adityagoel4512
Ensure Lint CI catch documentation difference error (onnx#5367)
2cb6094 
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
onnx#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@justinchuby @adityagoel4512
Remove proto generation step in test CIs (onnx#5344)
09f6f62 
### Description

Remove proto generation step in test CIs

### Motivation and Context

They are tested already by
https://github.com/onnx/onnx/blob/3e8a344785e9e1fe9260c3691f8c1daca7572024/.github/workflows/lint.yml

Signed-off-by: Justin Chu <justinchu@microsoft.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@jcwchen @adityagoel4512
Ensure Lint CI catch documentation difference error (onnx#5367)
c045327 
### Description
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
onnx#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@jcwchen @adityagoel4512
Ensure Lint CI catch documentation difference error (onnx#5367)
7888528 
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
onnx#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@jcwchen @adityagoel4512
Ensure Lint CI catch documentation difference error (onnx#5367)
019a2ec 
### Description
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md

### Motivation and Context
<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
onnx#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512 pushed a commit to adityagoel4512/onnx that referenced this pull request Jul 28, 2023
@jcwchen @adityagoel4512
Ensure Lint CI catch documentation difference error (onnx#5367)
882232e 
<!-- - Describe your changes. -->
Ensure Lint CI catch documentation diff (Operators.md) error: specify
ONNX_ML=0 and ONNX_ML=1 to update Operators.md and Operators-ml.md

<!-- - Why is this change required? What problem does it solve? -->
<!-- - If it fixes an open issue, please link to the issue here. -->
onnx#5344 we removed doc diff in required
Azp CI and now only Lint CI has doc diff check. However, documentation
diff in Lint CI seems not working. This PR is trying to ensure doc diff
errors will be caught.

---------

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcwchen jcwchen jcwchen approved these changes

Assignees
No one assigned
Labels
module: CI pipelines Issues related to the CI pipeline topic: code style Issues related to coding style or the linter
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinchuby @jcwchen