Update OpSchema docs to include new methods and classes #5297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2edd8b6 to
cc60938
Compare
cc60938 to
72e6edc
Compare
Signed-off-by: Justin Chu <justinchu@microsoft.com>
72e6edc to
8dec575
Compare
liqunfu
approved these changes
Jun 12, 2023
jcwchen
reviewed
Jun 12, 2023
There was a problem hiding this comment.
https://github.com/onnx/onnx/blob/main/docs/PythonAPIOverview.md is another entry point for new ONNX users. It would be useful if ONNX can have some examples for these new methods I think.
|
Should we migrate this markdown to the onnx docs website? The info seems to be redundant? |
PythonAPIOverview.md is more like an overview only with important APIs. Some of APIs are not included I think. Currently I don't see similar section on the web? Still, thank you for the PR of moving PythonAPIOverview.md to the web: #5312. |
|
I can migrate the doc to the index page for APIs in the online doc |
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
Signed-off-by: Justin Chu <justinchu@microsoft.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update OpSchema docs
Fixes #5292