Fix check_tensor to work with large models on Windows #5227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gramalingam
reviewed
May 14, 2023
|
You need to sign your commit (git commit -s ...) to make the DCO pass or follow the instructions after clicking on details. |
Signed-off-by: Patrice Vignola <vignola.patrice@gmail.com>
d0ac30a to
6f4051a
Compare
jcwchen
approved these changes
Jun 5, 2023
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
Signed-off-by: Patrice Vignola <vignola.patrice@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
5 tasks
yuanyao-nv
pushed a commit
to yuanyao-nv/onnx
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Patrice Vignola <vignola.patrice@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com>
yuanyao-nv
pushed a commit
to yuanyao-nv/onnx
that referenced
this pull request
Aug 7, 2023
Signed-off-by: Patrice Vignola <vignola.patrice@gmail.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Xavier Dupré <xadupre@users.noreply.github.com> Signed-off-by: Yuan Yao <yuanyao@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix check_tensor to work with large models
Motivation and Context
Calling check_tensor on large 7B+ LLM models currently fails because the size doesn't fit in int32, so using
_wstat64instead fixes the problem.