Improve error handling in empty list input for helper.make_attribute #5220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: twata <twata@preferred.jp>
bb84206 to
5099f4c
Compare
xadupre
reviewed
May 11, 2023
take-cheeze
commented
May 11, 2023
Signed-off-by: Takeshi Watanabe <take-cheeze@users.noreply.github.com>
take-cheeze
commented
May 11, 2023
Signed-off-by: Takeshi Watanabe <take-cheeze@users.noreply.github.com>
gramalingam
approved these changes
May 12, 2023
q-ycong-p
pushed a commit
to q-ycong-p/onnx
that referenced
this pull request
May 18, 2023
…nnx#5220) Signed-off-by: twata <twata@preferred.jp> Signed-off-by: Takeshi Watanabe <take-cheeze@users.noreply.github.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Yu Cong <congyc@amazon.com>
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
…nnx#5220) Signed-off-by: twata <twata@preferred.jp> Signed-off-by: Takeshi Watanabe <take-cheeze@users.noreply.github.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5216
Motivation and Context
Empty list input should raise type inference failure and attribute type should be able to specified explicitly