Transpose scalar shape inference #5204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f24c5a to
a0106ea
Compare
Signed-off-by: Bryan Anderson <andembry@amazon.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
* Add function inliner part 1 Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Inliner for model-local functions Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Minor fixes Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Export inliner to python Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Fix emptied files Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * remove constexpr Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Replace move by copy Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Run formatter Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Format file Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Check names are unique Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * naming conventions Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Test for opset mistmatch Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Remove move Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Address PR feedback Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add testcase with two calls to same function Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Comment debugging code Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Add comments about renaming Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> * Run formatter Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Signed-off-by: ideal <40137309+slowlyideal@users.noreply.github.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
1d8dc45 to
d5fe868
Compare
gramalingam
reviewed
May 10, 2023
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Signed-off-by: Aditya Goel <agoel4512@gmail.com>
…onnx#5210) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
…023 (onnx#5208) Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Signed-off-by: ideal <40137309+slowlyideal@users.noreply.github.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
…nnx#5169) Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
abbf137 to
13dc5b1
Compare
gramalingam
approved these changes
May 10, 2023
adityagoel4512
added a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
Signed-off-by: Bryan Anderson <andembry@amazon.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: jbachurski <kbachurski@gmail.com> Signed-off-by: ideal <40137309+slowlyideal@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Bryan Anderson <andembry@amazon.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Co-authored-by: Jakub Bachurski <kbachurski@gmail.com> Co-authored-by: ideal <40137309+slowlyideal@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shape inference when transposing scalars.
Motivation and Context
Currently when transposing a scalar, the output shape is left unset leading to Shape Inference errors. This PR makes sure this doesn't happen by ensuring the output type has a 0 dimensional shape for scalar inputs.