Modify OneHot operator explanation #5197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
referring to https://github.com/onnx/onnx/blob/main/onnx/defs/tensor/defs.cc#L2676-L2683 Signed-off-by: Bryan Anderson <andembry@amazon.com>
|
I see there is one python3.7 test failure. I don't see how these doc changes could've caused that, but at any rate it should be resolved by the python3.7 EOL PR. |
gramalingam
approved these changes
May 3, 2023
jcwchen
approved these changes
May 4, 2023
There was a problem hiding this comment.
I see there is one python3.7 test failure. I don't see how these doc changes could've caused that, but at any rate it should be resolved by the #5191.
I rerun the CI and now that one has passed. Thanks for improving the document!
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
May 9, 2023
Signed-off-by: Bryan Anderson <andembry@amazon.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
Signed-off-by: Bryan Anderson <andembry@amazon.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
referring to https://github.com/onnx/onnx/blob/main/onnx/defs/tensor/defs.cc#L2676-L2683
Description
Onehot operator should support scalar and tensor with rank 1 both for depth input.
Previous PR by my teammate was here. I made the changes mentioned by @xadupre in that PR: modified Operators.md, built the package and ran gen_doc.py, and signed the commit.
Motivation and Context