-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix shape inference errors for map
type
#5188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jbachurski <kbachurski@gmail.com>
Signed-off-by: jbachurski <kbachurski@gmail.com>
Signed-off-by: jbachurski <kbachurski@gmail.com>
Signed-off-by: jbachurski <kbachurski@gmail.com>
Signed-off-by: jbachurski <kbachurski@gmail.com>
Signed-off-by: jbachurski <kbachurski@gmail.com>
4dc49a2
to
7abb97a
Compare
xadupre
reviewed
May 2, 2023
Signed-off-by: jbachurski <kbachurski@gmail.com>
Signed-off-by: jbachurski <kbachurski@gmail.com>
xadupre
approved these changes
May 3, 2023
gramalingam
reviewed
May 3, 2023
gramalingam
reviewed
May 3, 2023
Signed-off-by: jbachurski <kbachurski@gmail.com>
744ffc8
to
4903f5d
Compare
Signed-off-by: jbachurski <kbachurski@gmail.com>
c11161b
to
644ccb1
Compare
gramalingam
approved these changes
May 3, 2023
gramalingam
reviewed
May 3, 2023
Signed-off-by: jbachurski <kbachurski@gmail.com>
Signed-off-by: jbachurski <kbachurski@gmail.com>
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
May 5, 2023
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
May 9, 2023
8 tasks
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
map
-typed operator was used.Motivation and Context
ONNX support for the
map
type is poor and the least documented. This is a small step towards adding more operators usingmap
for more advanced pre-processing capabilities, more dynamic than what is allowed by the existing, attribute-oriented,ai.onnx.ml
operators (likeLabelEncoder
).Currently, any and all uses of shape inference where a
map
type is present results in the following error (e.g. forZipMap
):This is due to a piece of code unrelated to a specific inference implementation, and hence map operators cannot be used at all as they will always raise this error. The shape inference test module had a similar lack of a map case. I skimmed through the code and I didn't see other such cases.
Also, related comment where I uncovered this -
skl2onnx
-produced classifiers useZipMap
by default and hence can never succeed in shape inference.