Skip to content

Update sphinx to create markdown pages for operators #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2023
Merged

Update sphinx to create markdown pages for operators #5137

merged 4 commits into from
Apr 17, 2023

Conversation

justinchuby
Copy link
Member

@justinchuby justinchuby commented Apr 15, 2023 •
edited
Loading

Description

  • Use the myst plugin
  • Clean up

Motivation and Context

Easier format for operator docs

image

Fixes #5128

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 15, 2023
View reviewed changes
@justinchuby
Copy link
Member Author

Renders:

image

image

Diff links work:

image

image

@justinchuby

This comment was marked as resolved.

Sign in to view
@justinchuby
Copy link
Member Author

justinchuby commented Apr 16, 2023 •
edited
Loading

sidebars, links and diffs are normal:
image

image

@justinchuby
Update sphinx to create markdown pages for operators
78a57f5 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby marked this pull request as ready for review April 16, 2023 05:53
@justinchuby justinchuby requested a review from a team as a code owner April 16, 2023 05:53
@justinchuby justinchuby mentioned this pull request Apr 16, 2023
Closed
@xadupre
Copy link
Contributor

xadupre commented Apr 16, 2023

It looks nice.

justinchuby
justinchuby commented Apr 16, 2023
View reviewed changes
justinchuby
justinchuby commented Apr 16, 2023
View reviewed changes
justinchuby
justinchuby commented Apr 16, 2023
View reviewed changes
justinchuby
justinchuby commented Apr 16, 2023
View reviewed changes
justinchuby
justinchuby commented Apr 16, 2023
View reviewed changes
@justinchuby
Apply suggestions from code review
e17fdad 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@jcwchen jcwchen added the website content related to https://onnx.ai/onnx/ label Apr 16, 2023
@justinchuby
Show links
6880a22 
Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby
Copy link
Member Author

@jcwchen I think this can be merged. thanks!

@jcwchen jcwchen merged commit d4b25d9 into onnx:main Apr 17, 2023
@justinchuby justinchuby mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xadupre xadupre xadupre approved these changes

Assignees
No one assigned
Labels
website content related to https://onnx.ai/onnx/
Projects
PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cast-19 table in onnx.ai docs is broken
3 participants
@justinchuby @xadupre @jcwchen