Fix shape inference for STFT batch dimension #5088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatriceVignola
approved these changes
Apr 4, 2023
gramalingam
approved these changes
Apr 5, 2023
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.2 to 2.1.3. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@e38b190...80e868c) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Sheil Kumar <smk2007@gmail.com>
… AzurePipelines (onnx#5057) * clean up CIs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * rename .yml instead of .yaml for consistency Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * windows CI Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> Signed-off-by: Sheil Kumar <smk2007@gmail.com>
* Fix reference implementation for Pad Signed-off-by: xadupre <xadupre@microsoft.com> * add unit test Signed-off-by: xadupre <xadupre@microsoft.com> * use parameterized Signed-off-by: xadupre <xadupre@microsoft.com> * check type Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: Sheil Kumar <smk2007@gmail.com>
…onnx#4960) * Add expected outputs for light models to make the backend test faster Signed-off-by: xadupre <xadupre@microsoft.com> * add expected outputs Signed-off-by: xadupre <xadupre@microsoft.com> * add missing outputs Signed-off-by: xadupre <xadupre@microsoft.com> * add missing expected output Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * skip failing test for onnxruntime Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * use range as well Signed-off-by: xadupre <xadupre@microsoft.com> * fix a bug Signed-off-by: xadupre <xadupre@microsoft.com> * exception Signed-off-by: xadupre <xadupre@microsoft.com> * fix light models by lower the fill value of ConstantOfShape nodes Signed-off-by: xadupre <xadupre@microsoft.com> * lint Signed-off-by: xadupre <xadupre@microsoft.com> * fix type issue in deform implementation Signed-off-by: xadupre <xadupre@microsoft.com> * exclude deformconv from onnxruntime backend test series Signed-off-by: xadupre <xadupre@microsoft.com> * disable test when numpy is not recent enough Signed-off-by: xadupre <xadupre@microsoft.com> * move one test Signed-off-by: xadupre <xadupre@microsoft.com> * avoid python 3.7 Signed-off-by: xadupre <xadupre@microsoft.com> * add missing import Signed-off-by: xadupre <xadupre@microsoft.com> * fix import Signed-off-by: xadupre <xadupre@microsoft.com> * add missing license Signed-off-by: xadupre <xadupre@microsoft.com> * add copyright for binary file Signed-off-by: xadupre <xadupre@microsoft.com> --------- Signed-off-by: xadupre <xadupre@microsoft.com> Co-authored-by: Chun-Wei Chen <jacky82226@gmail.com> Signed-off-by: Sheil Kumar <smk2007@gmail.com>
Signed-off-by: Sheil Kumar <smk2007@gmail.com>
* add clang-tidy review Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * more configs Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * add post yml Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * rename Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * post Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * orkflow_dispatch Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * Post clang-tidy review comments Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * remove workflow Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * test Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> * revert demo Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> --------- Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com> Co-authored-by: Andreas Fehlner <fehlner@arcor.de> Signed-off-by: Sheil Kumar <smk2007@gmail.com>
* [WIP] Upgrade Protobuf to v21.1 to accept Python Protobuf 4.21
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* then
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* Same as previous PR
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* fix CIs
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* 3.21.12
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* build protobuf from source on Linux
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* static protobuf
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* protoc --version
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* $BUILD_TYPE
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* printenv PATH
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* path
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* onnx-protobufv21
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* test 3.20.2
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* Protobuf 4 and Protobuf 3 will output different order of protobuf fields.
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* skip
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* %%script --no-raise-error false
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* updated
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* test lower protoc
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* export CMAKE_ARGS="-DONNX_WERROR=ON -DONNX_USE_PROTOBUF_SHARED_LIBS=ON"
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* fix
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* still test protobuf==3.20.2 at least in a CI
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* update Protobufs.ipynb
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* ["nbreg"] = {"skip": True, "skip_reason": "Not ready for testing."}
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* NBVAL_SKIP
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
* use " instead of '
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
---------
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Sheil Kumar <smk2007@gmail.com>
* Update README.md --------- Signed-off-by: Andreas Fehlner <fehlner@arcor.de> Signed-off-by: Sheil Kumar <smk2007@gmail.com>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de> Signed-off-by: Sheil Kumar <smk2007@gmail.com>
auto-merge was automatically disabled
April 5, 2023 17:51
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix shape inference for STFT batch dimension
The shape inference function currently incorrectly assigns a batch dimension when the input shape has no dim value.
In the case where the input shape has no dim value, the batch dimension should be unset.