Faster reference implementation for operator Conv based on im2col #5069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
justinchuby
reviewed
Apr 7, 2023
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com>
|
A general idea (applies to both Shall we adopt some naming convention for the methods in the classes that implement the ops to support this? So, for example, your naive implementation of im2col can go back into the main class (instead of being in the testing code). We just use an appropriate suffix to distinguish the two implementations. Eg., may be add |
Signed-off-by: xadupre <xadupre@microsoft.com>
justinchuby
reviewed
Apr 25, 2023
justinchuby
reviewed
Apr 25, 2023
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
Signed-off-by: xadupre <xadupre@microsoft.com>
gramalingam
reviewed
May 9, 2023
gramalingam
reviewed
May 9, 2023
Signed-off-by: xadupre <xadupre@microsoft.com>
gramalingam
approved these changes
May 10, 2023
adityagoel4512
pushed a commit
to adityagoel4512/onnx
that referenced
this pull request
Jul 28, 2023
…nx#5069) Signed-off-by: xadupre <xadupre@microsoft.com> Signed-off-by: Xavier Dupré <xadupre@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Aditya Goel <agoel4512@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current implementation of Operator Conv is very slow. This is a faster one based on im2col.
Measures with shape(X)=(1, 1, 64, 64), shape(kernel)=(3, 3), before time is 0.0033s, after time is 0.00075, > 4 times faster. This ratio is higher with bigger matrices.
Motivation and Context
Performance.