Fix onnx.compose when connecting subgraphs
#5991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5991 +/- ##
==========================================
- Coverage 56.82% 56.81% -0.01%
==========================================
Files 506 506
Lines 30365 30370 +5
Branches 4590 4592 +2
==========================================
+ Hits 17254 17256 +2
- Misses 12283 12285 +2
- Partials 828 829 +1 ☔ View full report in Codecov by Sentry. |
gramalingam
approved these changes
Mar 4, 2024
justinchuby
reviewed
Mar 4, 2024
Signed-off-by: Abhishek-TyRnT <kulkarnia168@gmail.com>
Signed-off-by: Abhishek-TyRnT <kulkarnia168@gmail.com>
Signed-off-by: Abhishek-TyRnT <kulkarnia168@gmail.com>
595be55 to
570e23e
Compare
justinchuby
reviewed
Mar 5, 2024
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
reviewed
Mar 5, 2024
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
approved these changes
Mar 5, 2024
onnx.compose when connecting subgraphs
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
Mar 18, 2024
### Description Recursively searching through the nodes for input in merge graphs function. ### Motivation and Context While connecting and merging two models in which there is subgraph in one of them, inputs and outputs of subgraph was being overlooked and were left dangling. This fixes onnx#5985 --------- Signed-off-by: Abhishek-TyRnT <kulkarnia168@gmail.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: isdanni <leedanni@gmail.com>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description Recursively searching through the nodes for input in merge graphs function. ### Motivation and Context While connecting and merging two models in which there is subgraph in one of them, inputs and outputs of subgraph was being overlooked and were left dangling. This fixes onnx#5985 --------- Signed-off-by: Abhishek-TyRnT <kulkarnia168@gmail.com> Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recursively searching through the nodes for input in merge graphs function.
Motivation and Context
While connecting and merging two models in which there is subgraph in one of them, inputs and outputs of subgraph was being overlooked and were left dangling.
This fixes #5985