Handle OneHot's depth value during shape inference
#5963
Merged
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneHot's depth value during shape inference
maekawatoshiki
commented
Feb 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5963 +/- ##
=======================================
Coverage 56.81% 56.82%
=======================================
Files 506 506
Lines 30370 30376 +6
Branches 4592 4592
=======================================
+ Hits 17256 17262 +6
Misses 12285 12285
Partials 829 829 ☔ View full report in Codecov by Sentry. |
0d5950d to
8b38853
Compare
Signed-off-by: maekawatoshiki <maekawatoshiki1017@gmail.com>
Signed-off-by: maekawatoshiki <maekawatoshiki1017@gmail.com>
Signed-off-by: maekawatoshiki <maekawatoshiki1017@gmail.com>
|
How's the review process going? |
|
LGTM. I will leave this to @SIG-operators-approvers reviewers |
gramalingam
approved these changes
Mar 26, 2024
andife
pushed a commit
to andife/onnx
that referenced
this pull request
Jul 20, 2024
### Description - Even if the `depth` value of `OneHot` is specified as an initializer, the value is ignored during shape inference currently. - This is a correct shape inference from my understanding, but let me if this is wrong. --------- Signed-off-by: maekawatoshiki <maekawatoshiki1017@gmail.com> Co-authored-by: Ke Zhang <linkerzhang@yeah.net> Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description - Even if the `depth` value of `OneHot` is specified as an initializer, the value is ignored during shape inference currently. - This is a correct shape inference from my understanding, but let me if this is wrong. --------- Signed-off-by: maekawatoshiki <maekawatoshiki1017@gmail.com> Co-authored-by: Ke Zhang <linkerzhang@yeah.net> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
depthvalue ofOneHotis specified as an initializer, the value is ignored during shape inference currently.