Fix ConstantOfShape type constraints #5961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boolean type was unintentionally dropped in onnx#5811. Revert to previous version and add the new types uint4, int4. Modify type constraint comment to mention boolean is allowed. Signed-off-by: Gal Hubara Agam <ghubaraagam@nvidia.com>
|
@cjvolzka thanks for pointing that out. Fixed in this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5961 +/- ##
=======================================
Coverage 56.68% 56.68%
=======================================
Files 506 506
Lines 30231 30231
Branches 4566 4566
=======================================
Hits 17137 17137
Misses 12268 12268
Partials 826 826 ☔ View full report in Codecov by Sentry. |
gramalingam
approved these changes
Feb 23, 2024
cjvolzka
approved these changes
Feb 23, 2024
|
Looks like this failure is not related to my changes |
justinchuby
reviewed
Feb 24, 2024
| @@ -90,7 +90,28 @@ ONNX_OPERATOR_SET_SCHEMA( | |||
| "defaults to float32.", | |||
| "T2") | |||
| .TypeConstraint("T1", {"tensor(int64)"}, "Constrain input types.") | |||
| .TypeConstraint("T2", OpSchema::all_numeric_types_ir10(), "Constrain output types to be numerics.") | |||
There was a problem hiding this comment.
Possible to create a new function to generate this list?
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
Boolean type was unintentionally dropped in onnx#5811. Revert to previous version and add the new types uint4, int4. Modify type constraint comment to mention boolean is allowed. Signed-off-by: Gal Hubara Agam <ghubaraagam@nvidia.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean type was unintentionally dropped in #5811.
Revert to previous version and add the new types uint4, int4.
Modify type constraint comment to mention boolean is allowed.