Skip to content

Conversation

gramalingam
Copy link
Contributor

Description

This is a follow up to the PR adding valueinfos field to FunctionProto. This PR updates the inliner to propagate this information from the inlined function.

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam gramalingam requested a review from a team as a code owner February 17, 2024 04:38
@gramalingam gramalingam added this to the 1.16 milestone Feb 17, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.79%. Comparing base (4a51870) to head (c348351).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5942   +/-   ##
=======================================
  Coverage   56.79%   56.79%           
=======================================
  Files         506      506           
  Lines       30308    30308           
  Branches     4580     4580           
=======================================
  Hits        17214    17214           
  Misses      12267    12267           
  Partials      827      827           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@gramalingam gramalingam added this pull request to the merge queue Feb 25, 2024
Merged via the queue into onnx:main with commit 7ddb57c Feb 25, 2024
@gramalingam gramalingam deleted the inliner-valueinfo branch February 25, 2024 02:31
cjvolzka added a commit that referenced this pull request Feb 26, 2024
* 'main' of https://github.com/onnx/onnx:
  Add attribute output_dtype to QuantizeLinear (#5956)
  Update inliner to propagate valueinfos (#5942)
  Fix ConstantOfShape type constraints (#5961)
  Support register custom OpSchema by python (#5906)
  Fix ReferenceEvaluator when run from a subclass (#5936)
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
### Description

This is a follow up to the PR adding valueinfos field to FunctionProto.
This PR updates the inliner to propagate this information from the
inlined function.

---------

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants