Update proto to add metadata props #5938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5938 +/- ##
=======================================
Coverage 56.64% 56.65%
=======================================
Files 506 506
Lines 30201 30203 +2
Branches 4558 4558
=======================================
+ Hits 17108 17110 +2
Misses 12268 12268
Partials 825 825 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
thiagocrepaldi
approved these changes
Feb 16, 2024
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
justinchuby
approved these changes
Feb 17, 2024
|
@gramalingam @justinchuby can you share a few sample files showing how this is used? |
|
@lutzroeder : the standard does not define any specific metadata, and it is upto users how they use this. This is to address requests by users to store extra data, for example layer-information for nodes. |
|
@gramalingam is there a way to link to these requests? I'm trying to understand potential usage patterns. |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
Followup of #5938 to add similar metadata field to ValueInfoProto as well. --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
isdanni
pushed a commit
to isdanni/onnx
that referenced
this pull request
Mar 18, 2024
Followup of onnx#5938 to add similar metadata field to ValueInfoProto as well. --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: isdanni <leedanni@gmail.com>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
Update proto to add metadata props to NodeProto, GraphProto, and FunctionProto to store extra metadata in those structures. --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
Followup of onnx#5938 to add similar metadata field to ValueInfoProto as well. --------- Signed-off-by: Ganesan Ramalingam <grama@microsoft.com> Signed-off-by: Linsho Kaku <linsho@preferred.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update proto to add metadata props to NodeProto, GraphProto, and FunctionProto to store extra metadata in those structures.